Add regression tests for POLYGON pad shape components - #381
Open
fengfirewudi wants to merge 2 commits into
Open
Conversation
Add test cases for C5360621, C2879853, and C9900014805 which previously failed to import due to POLYGON not being recognized as a valid pad shape. These components now parse and convert correctly with existing POLYGON support. Closes tscircuit#218, closes tscircuit#239, closes tscircuit#240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Issues #218, #239, and #240 reported that these JLCPCB parts failed to import with the error:
POLYGON pad shape support has since been added to the schema and conversion logic. These tests confirm the fix and prevent regressions.
Closes #218
Closes #239
Closes #240
Test plan
bun test)